Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show loading banner when blockaid toggled #8013

Merged
merged 15 commits into from
Dec 7, 2023

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Dec 6, 2023

Description

When ppom is initialised on mobile, we notice that some devices experiences performance issues within the first couple seconds. Having this loading banner helps improve this experience for these devices.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1769

Manual testing steps

  1. Go to Settings
  2. Go to the Experimental
  3. Toggle blockaid on

Screenshots/Recordings

Before

After

Screen.Recording.2023-12-06.at.17.29.27.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa changed the title initial commit loading UI Dec 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (46c1cea) 37.09% compared to head (a648e1a) 37.06%.
Report is 1 commits behind head on main.

Files Patch % Lines
...alSettings/BlockaidIndicator/BlockaidIndicator.tsx 3.70% 26 Missing ⚠️
...ents/Views/Settings/ExperimentalSettings/index.tsx 33.33% 4 Missing ⚠️
app/actions/experimental/index.ts 0.00% 1 Missing ⚠️
...omponents/BottomSheets/BottomSheet/BottomSheet.tsx 0.00% 1 Missing ⚠️
...ings/BlockaidIndicator/BlockaidIndicator.styles.ts 50.00% 1 Missing ⚠️
app/core/Engine.ts 0.00% 1 Missing ⚠️
app/reducers/experimentalSettings/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8013      +/-   ##
==========================================
- Coverage   37.09%   37.06%   -0.04%     
==========================================
  Files        1131     1135       +4     
  Lines       29118    29150      +32     
  Branches     2722     2728       +6     
==========================================
+ Hits        10801    10803       +2     
- Misses      17694    17724      +30     
  Partials      623      623              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackdevelopa blackdevelopa changed the title loading UI fix: show loading banner when blockaid toggled Dec 6, 2023
@blackdevelopa blackdevelopa self-assigned this Dec 6, 2023
@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Dec 6, 2023
brianacnguyen
brianacnguyen previously approved these changes Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9be52cdf-5e79-4f40-ab60-541fd1821600
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

socket-security bot commented Dec 6, 2023

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@segun segun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

segun
segun previously approved these changes Dec 7, 2023
jpuri
jpuri previously approved these changes Dec 7, 2023
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved changes to DS

Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

11.1% 11.1% Coverage
0.0% 0.0% Duplication

@blackdevelopa blackdevelopa merged commit c482c7d into main Dec 7, 2023
52 checks passed
@blackdevelopa blackdevelopa deleted the 1769/loading_ui_blockaid branch December 7, 2023 19:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants