-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show loading banner when blockaid toggled #8013
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8013 +/- ##
==========================================
- Coverage 37.09% 37.06% -0.04%
==========================================
Files 1131 1135 +4
Lines 29118 29150 +32
Branches 2722 2728 +6
==========================================
+ Hits 10801 10803 +2
- Misses 17694 17724 +30
Partials 623 623 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9be52cdf-5e79-4f40-ab60-541fd1821600 |
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
app/components/Views/Settings/ExperimentalSettings/blockaidIndicator.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/Settings/ExperimentalSettings/blockaidIndicator.tsx
Outdated
Show resolved
Hide resolved
6e52ec0
to
cec9ebd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
app/components/Views/Settings/ExperimentalSettings/blockaidIndicator.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/Settings/ExperimentalSettings/ExperimentalSettings.styles.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved changes to DS
Kudos, SonarCloud Quality Gate passed! |
Description
When ppom is initialised on mobile, we notice that some devices experiences performance issues within the first couple seconds. Having this loading banner helps improve this experience for these devices.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1769
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2023-12-06.at.17.29.27.mov
Pre-merge author checklist
Pre-merge reviewer checklist