-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Batch 4 Remove all instances of strings in TestID property in the app code #8014
test: Batch 4 Remove all instances of strings in TestID property in the app code #8014
Conversation
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8014 +/- ##
=======================================
Coverage 38.90% 38.90%
=======================================
Files 1198 1198
Lines 29729 29729
Branches 2829 2829
=======================================
Hits 11566 11566
Misses 17479 17479
Partials 684 684 ☔ View full report in Codecov by Sentry. |
…rings-in-testid-property-in-the-app-code
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b7f7829c-ea0b-44c5-b2ff-23a902b537b0 |
…rings-in-testid-property-in-the-app-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments @SamuelSalas
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6cb82fee-c55a-4c6b-a5a6-926eba229dd0 |
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
…rings-in-testid-property-in-the-app-code
Quality Gate failedFailed conditions 4.9% Duplication on New Code (required ≤ 3%) |
Description
Replace all string definitions used for testIDs. These files should no longer selector strings in the TestID prop:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6cb82fee-c55a-4c6b-a5a6-926eba229dd0
Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef0b5a0b-171b-4819-ad4b-7f598fee427b
Appium test run: https://app.bitrise.io/build/39801a05-be41-4010-9c6c-8ef85b26b732
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist