Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Batch 4 Remove all instances of strings in TestID property in the app code #8014

Conversation

SamuelSalas
Copy link
Member

@SamuelSalas SamuelSalas commented Dec 6, 2023

Description

Replace all string definitions used for testIDs. These files should no longer selector strings in the TestID prop:

  • app/components/Views/AccountBackupStep1/index.js
  • app/components/Views/AccountBackupStep1B/index.js
  • app/components/Views/AddAsset/AddAsset.tsx
  • app/components/Views/AddBookmark/index.js
  • app/components/Views/AddressQRCode/index.js
  • app/components/Views/ChoosePassword/index.js
  • app/components/Views/Collectible/index.js

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6cb82fee-c55a-4c6b-a5a6-926eba229dd0
Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef0b5a0b-171b-4819-ad4b-7f598fee427b
Appium test run: https://app.bitrise.io/build/39801a05-be41-4010-9c6c-8ef85b26b732

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7869a6) 38.90% compared to head (42cee99) 38.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8014   +/-   ##
=======================================
  Coverage   38.90%   38.90%           
=======================================
  Files        1198     1198           
  Lines       29729    29729           
  Branches     2829     2829           
=======================================
  Hits        11566    11566           
  Misses      17479    17479           
  Partials      684      684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b7f7829c-ea0b-44c5-b2ff-23a902b537b0
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@metamaskbot metamaskbot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Dec 7, 2023
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments @SamuelSalas

@metamaskbot metamaskbot added in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6cb82fee-c55a-4c6b-a5a6-926eba229dd0
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@metamaskbot metamaskbot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Dec 12, 2023
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

4.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sethkfman sethkfman merged commit 9462ead into main Dec 13, 2023
25 of 26 checks passed
@sethkfman sethkfman deleted the test/7868-batch-4-remove-all-instances-of-strings-in-testid-property-in-the-app-code branch December 13, 2023 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 13, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Batch 4/7] Remove all instances of strings in TestID property in the app code
7 participants