Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): add sell deeplink #8016

Merged
merged 1 commit into from
Dec 8, 2023
Merged

feat(ramp): add sell deeplink #8016

merged 1 commit into from
Dec 8, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Dec 6, 2023

Description

This PR adds the handling for the Sell flow deeplink, the same way we did for Buy flow in #5743:

This PR adds support for metamask://sell-crypto and https://metamask.app.link/sell-crypto, these will open the sell flow.

Related issues

Fixes:

Manual testing steps

  1. Navigate to metamask://sell-crypto or https://metamask.app.link/sell-crypto
  2. Sell flow must open

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei requested a review from a team as a code owner December 6, 2023 17:00
@wachunei wachunei mentioned this pull request Dec 6, 2023
13 tasks
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Dec 6, 2023
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@bkirb
Copy link
Contributor

bkirb commented Dec 7, 2023

@wachunei LGTM I verified both deeplinks ✅

@wachunei wachunei removed the needs-ramp-qa Tickets that need feature QA on the ramps flows label Dec 7, 2023
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgeweiler georgeweiler merged commit 547cf76 into main Dec 8, 2023
37 checks passed
@georgeweiler georgeweiler deleted the feat/ramp-deeplink-sell branch December 8, 2023 22:15
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants