Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace Settings drawer with DS components and update design #8037

Merged
merged 15 commits into from
Jan 30, 2024
Merged

refactor: Replace Settings drawer with DS components and update design #8037

merged 15 commits into from
Jan 30, 2024

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Dec 7, 2023 •
edited

Description

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.13.-.2023-12-07.at.11.03.23.mp4

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-12-19.at.20.23.50.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile Run Smoke E2E labels Dec 7, 2023
@brianacnguyen brianacnguyen self-assigned this Dec 7, 2023
@brianacnguyen brianacnguyen requested review from a team as code owners December 7, 2023 19:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen changed the title update: Replace Settings drawer with DS components and update design refactor: Replace Settings drawer with DS components and update design Dec 7, 2023
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9f1d68e0-4d6c-439b-acfc-d8f38bcdfc0c
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

georgewrmarshall
georgewrmarshall previously approved these changes Dec 8, 2023
View reviewed changes
app/components/UI/Navbar/index.js Outdated Show resolved Hide resolved
@georgewrmarshall
Copy link
Contributor

Question for design
Screenshot 2023-12-08 at 12 22 00 PM

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023 •
edited

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (266154a) 40.42% compared to head (18d6a20) 40.41%.

Files Patch % Lines
app/components/Views/Settings/index.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8037      +/-   ##
==========================================
- Coverage   40.42%   40.41%   -0.02%     
==========================================
  Files        1239     1239              
  Lines       29976    29977       +1     
  Branches     2869     2870       +1     
==========================================
- Hits        12117    12114       -3     
- Misses      17168    17171       +3     
- Partials      691      692       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

georgewrmarshall
georgewrmarshall reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but you are missing manual testing steps and checklist in PR template

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen merged commit 97682bc into main Jan 30, 2024
26 checks passed
@brianacnguyen brianacnguyen deleted the replace-settings-drawer branch January 30, 2024 00:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 30, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 30, 2024
wachunei
wachunei reviewed Jan 30, 2024
View reviewed changes
app/components/UI/SettingsDrawer/index.js
@@ -95,7 +76,7 @@ const propTypes = {
/**
* Title color
*/
titleColor: PropTypes.string,
titleColor: TextColor,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct, PropTypes only accept PropTypes properties. This is currently causing a warning on main.

Suggested change
titleColor: TextColor,
titleColor: PropTypes.string,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct, PropTypes only accept PropTypes properties. This is currently causing a warning on main.

PR to fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei left review comments

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.16.0 Issue or pull request that will be included in release 7.16.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brianacnguyen @georgewrmarshall @codecov-commenter @wachunei @Cal-L @metamaskbot