-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added RadioButton to DS #8047
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left some comments. Excellent PR description
- Check documentation, code
- Did not check render of storybook
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Checked documentation, code
- Did not check live in simulator
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8047 +/- ##
==========================================
+ Coverage 37.06% 37.10% +0.04%
==========================================
Files 1135 1139 +4
Lines 29150 29183 +33
Branches 2728 2740 +12
==========================================
+ Hits 10803 10827 +24
- Misses 17724 17730 +6
- Partials 623 626 +3 ☔ View full report in Codecov by Sentry. |
Description
RadioButton
component based on design https://www.figma.com/file/HKpPKij9V3TpsyMV1TpV7C/DS-Components?type=design&node-id=14243%3A38816&mode=design&t=GuHGe1YmY2n814yr-1Screenshots/Recordings
Before
N/A
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-12-07.at.15.37.41.mp4
Pre-merge author checklist
Pre-merge reviewer checklist