Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added RadioButton to DS #8047

Merged
merged 12 commits into from
Dec 8, 2023
Merged

feat: Added RadioButton to DS #8047

merged 12 commits into from
Dec 8, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Dec 7, 2023

Description

Screenshots/Recordings

Before

N/A

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-12-07.at.15.37.41.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Dec 7, 2023
@brianacnguyen brianacnguyen self-assigned this Dec 7, 2023
@brianacnguyen brianacnguyen requested review from a team as code owners December 7, 2023 23:41
Copy link
Contributor

github-actions bot commented Dec 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 7, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left some comments. Excellent PR description

  • Check documentation, code
  • Did not check render of storybook

app/component-library/components/RadioButton/README.md Outdated Show resolved Hide resolved
app/component-library/components/RadioButton/README.md Outdated Show resolved Hide resolved
app/component-library/components/RadioButton/README.md Outdated Show resolved Hide resolved
app/component-library/components/RadioButton/README.md Outdated Show resolved Hide resolved
app/component-library/components/RadioButton/README.md Outdated Show resolved Hide resolved
app/component-library/components/RadioButton/README.md Outdated Show resolved Hide resolved
app/component-library/components/RadioButton/README.md Outdated Show resolved Hide resolved
brianacnguyen and others added 9 commits December 8, 2023 11:35
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Checked documentation, code
  • Did not check live in simulator

Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.0% 83.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9196c02) 37.06% compared to head (d6b05fe) 37.10%.

Files Patch % Lines
...brary/components/RadioButton/RadioButton.styles.ts 56.25% 4 Missing and 3 partials ⚠️
...ary/components/RadioButton/RadioButton.stories.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8047      +/-   ##
==========================================
+ Coverage   37.06%   37.10%   +0.04%     
==========================================
  Files        1135     1139       +4     
  Lines       29150    29183      +33     
  Branches     2728     2740      +12     
==========================================
+ Hits        10803    10827      +24     
- Misses      17724    17730       +6     
- Partials      623      626       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianacnguyen brianacnguyen merged commit b77d86f into main Dec 8, 2023
28 checks passed
@brianacnguyen brianacnguyen deleted the morph/radio branch December 8, 2023 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 8, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants