-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace Security Settings page with DS components and updated design #8048
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/053c8fd5-08d6-4c0e-9ecb-f0c71eb6d418 |
…to replace-settings-security
…to replace-settings-security
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8048 +/- ##
==========================================
- Coverage 39.39% 39.37% -0.02%
==========================================
Files 1220 1220
Lines 29800 29787 -13
Branches 2831 2829 -2
==========================================
- Hits 11740 11729 -11
- Misses 17371 17372 +1
+ Partials 689 686 -3 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
Design Resources:
https://www.figma.com/file/5nRaF62WvJOUJc925ALacm/Setting-page-DS-sync-with-Brian-follow-up?type=design&node-id=0-1&mode=design&t=QC83o4maZi5lSOn0-0
https://www.figma.com/file/MlBUrNnIXlftX4TSjqiUYg/Core-Components?type=design&node-id=1061-12936&mode=design&t=vGWvpVcXE9tOaHhr-0
https://www.figma.com/file/t4Zc6ZOA9Urw8POrCReEam/Privacy-epic-%26-update-security-and-privacy-in-settings?type=design&node-id=178-21581&mode=design&t=7vAal9KHWKtzpPV7-0
Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-12-07.at.17.46.52.mp4
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-12-07.at.17.39.58.mp4
Pre-merge author checklist
Pre-merge reviewer checklist