Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo on PPOM modal text #8063

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: fix typo on PPOM modal text #8063

merged 1 commit into from
Dec 11, 2023

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Dec 11, 2023

Description

This PR fixes a typo on the Setup Completed modal text for Blockaid.
Security alerts are ready to go. You can close this pageand start exploring your wallet

Related issues

Fixes: #8062

Manual testing steps

  1. Enable Blockaid
  2. See Setup Completed modal text

Screenshots/Recordings

Before

image

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added the team-confirmations-secure-ux-PR PR from the confirmations team label Dec 11, 2023
@seaona seaona self-assigned this Dec 11, 2023
@seaona seaona marked this pull request as ready for review December 11, 2023 10:12
@seaona seaona requested a review from a team as a code owner December 11, 2023 10:12
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/afca0ae8-e912-4325-adff-de87299cf0f8
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c877b3) 37.14% compared to head (43229ee) 37.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8063   +/-   ##
=======================================
  Coverage   37.14%   37.14%           
=======================================
  Files        1139     1139           
  Lines       29196    29196           
  Branches     2746     2746           
=======================================
  Hits        10846    10846           
  Misses      17724    17724           
  Partials      626      626           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seaona seaona merged commit 8f23135 into main Dec 11, 2023
48 checks passed
@seaona seaona deleted the fix-ppom-modal-typo branch December 11, 2023 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - typo in Setup Completed modal setup_complete_description text
5 participants