Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync icon library with figma icon library #8073

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

Sync Icon's asset folder with Icons from Figma
https://www.figma.com/file/HKpPKij9V3TpsyMV1TpV7C/DS-Components?type=design&node-id=401%3A2122&mode=design&t=xMFUABEaqPDkcTTZ-1
Added

  • Home-2
  • Plant
  • Plus-and-minus
  • Snaps-round
  • Sparkle
  • Tint

Related issues

Fixes:

Manual testing steps

  1. Access storybook via changing the pointer in the index file
  2. Go to the Icon story
  3. Check all the new icons

Screenshots/Recordings

Before

N/A

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-12-11.at.17.12.08.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Dec 12, 2023
@brianacnguyen brianacnguyen self-assigned this Dec 12, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner December 12, 2023 01:24
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2641e0f) 37.14% compared to head (f694954) 37.15%.

Files Patch % Lines
...y/components/Icons/Icon/scripts/generate-assets.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8073   +/-   ##
=======================================
  Coverage   37.14%   37.15%           
=======================================
  Files        1139     1139           
  Lines       29196    29195    -1     
  Branches     2746     2746           
=======================================
  Hits        10846    10846           
+ Misses      17724    17723    -1     
  Partials      626      626           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit 98ac4da into main Dec 12, 2023
33 checks passed
@brianacnguyen brianacnguyen deleted the morph/update-icon branch December 12, 2023 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 12, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants