chore: split the Connection class into smaller chunks and add unit tests

[omridan159]

Description

Split the Connection class into smaller chunks to make the code more testable and add unit tests.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (d7869a6) 38.90% compared to head (5407c83) 39.27%.

Files	Patch %	Lines
...ction/EventListenersHandlers/handleClientsReady.ts	33.33%	6 Missing ⚠️
...n/EventListenersHandlers/handleClientsConnected.ts	66.66%	3 Missing and 1 partial ⚠️
app/core/SDKConnect/Connection/Connection.ts	93.61%	1 Missing and 2 partials ⚠️
.../core/SDKConnect/Connection/Auth/sendAuthorized.ts	80.00%	1 Missing ⚠️
...nnect/Connection/ConnectionLifecycle/disconnect.ts	83.33%	1 Missing ⚠️
...ventListenersHandlers/handleClientsDisconnected.ts	93.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8074      +/-   ##
==========================================
+ Coverage   38.90%   39.27%   +0.36%     
==========================================
  Files        1198     1208      +10     
  Lines       29729    29738       +9     
  Branches     2829     2828       -1     
==========================================
+ Hits        11566    11679     +113     
+ Misses      17479    17371     -108     
- Partials      684      688       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andreahaku]

LGTM

The base branch was changed.

[abretonc7s]

LGTM

Eventually we need to finalize a naming convention and enforce it via linters

[andreahaku]

LGTM

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue	Package	Version	Note	Source
Deprecated	figgy-pudding	3.5.2	Reason: This module is no longer supported.	@storybook/addon-ondevice-controls@6.5.6 via package.json
Potential typo squat	react-native-search-api	1.0.1	Did you mean: react-native-sfeartch-api (7 thousand times more downloads)	package.json

Next steps

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What is a potential typo squat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore figgy-pudding@3.5.2
• @SocketSecurity ignore react-native-search-api@1.0.1

[christopherferreira9]

Tests on iOS and Android:

• Overall smoke with a JS SDK dapp
• Overall smoke with an iOS SDK dapp
• Overall smoke with a Unity SDK dapp