Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PPOMController related issues in blockaid integration #8085

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 13, 2023

Description

The package updates to latest verison of ppom-validator, to leverage new fixes in PPOMController.

Related issues

Fixes: MetaMask/MetaMask-planning#1820

Manual testing steps

  1. Enable blockaid validation for user
  2. Go to test dapp and submit a malicious transaction
  3. It should show blockaid error

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner December 13, 2023 11:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/ppom-validator 0.14.0...0.15.0 None +0/-0 144 kB

Copy link

socket-security bot commented Dec 13, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/ppom-validator@0.15.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7869a6) 38.90% compared to head (0fb9d97) 38.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8085   +/-   ##
=======================================
  Coverage   38.90%   38.90%           
=======================================
  Files        1198     1198           
  Lines       29729    29729           
  Branches     2829     2829           
=======================================
  Hits        11566    11566           
  Misses      17479    17479           
  Partials      684      684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E labels Dec 13, 2023
@jpuri
Copy link
Contributor Author

jpuri commented Dec 13, 2023

@SocketSecurity ignore @metamask/ppom-validator@0.15.0

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/84821a80-91d6-4dbc-a0ec-ae5071e3e4c7
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@jpuri jpuri merged commit 2999b78 into main Dec 13, 2023
34 of 35 checks passed
@jpuri jpuri deleted the update_validator branch December 13, 2023 15:42
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 13, 2023
@gauthierpetetin gauthierpetetin added release-7.14.0 Issue or pull request that will be included in release 7.14.0 and removed release-7.15.0 Issue or pull request that will be included in release 7.15.0 labels Jan 2, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.14.0 on PR. Adding release label release-7.14.0 on PR and removing other release labels(release-7.15.0), as PR was added to branch 7.14.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants