test: Refactor Settings Contacts Folder page objects

[SamuelSalas]

Description

We are aiming to refactor the page objects in the onboarding folder so that they strictly follow the page object model pattern. This would aide in providing more readable and help standardize the way we create our tests.

Related issues

Fixes: 1330

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60dd3b08-e2c9-42b0-8ab0-7e65ef15f451
Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/418a60d9-c936-47a9-a3b1-3696bbc3b3ee

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/418a60d9-c936-47a9-a3b1-3696bbc3b3ee
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96567e2) 39.57% compared to head (7db433f) 39.57%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8087   +/-   ##
=======================================
  Coverage   39.57%   39.57%           
=======================================
  Files        1232     1232           
  Lines       29825    29825           
  Branches     2841     2841           
=======================================
  Hits        11803    11803           
  Misses      17328    17328           
  Partials      694      694           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cortisiko]

Left a few comments @SamuelSalas

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a5bd8f07-182a-40de-8062-33bead2d8c25
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[cortisiko]

✅ ✅ ✅ ✅

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud