-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: metrics event not fired when blockaid is disabled #8088
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a3ca1135-d278-45a4-b872-3428a507f33a |
app/components/Views/Settings/ExperimentalSettings/BlockaidIndicator/BlockaidIndicator.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8088 +/- ##
==========================================
- Coverage 39.39% 39.39% -0.01%
==========================================
Files 1220 1220
Lines 29800 29801 +1
Branches 2831 2831
==========================================
Hits 11740 11740
- Misses 17371 17372 +1
Partials 689 689 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Missing release label release-7.14.0 on PR. Adding release label release-7.14.0 on PR and removing other release labels(release-7.15.0), as PR was added to branch 7.14.0 when release was cut. |
Description
Metrics event not fired when blockaid is toggled off
Related issues
Fixes: #8064
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist