Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metrics event not fired when blockaid is disabled #8088

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 13, 2023

Description

Metrics event not fired when blockaid is toggled off

Related issues

Fixes: #8064

Manual testing steps

  1. Go to settings page
  2. Enable and then disable blockaid
  3. Check that metrics event if fired

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E labels Dec 13, 2023
@jpuri jpuri requested a review from a team as a code owner December 13, 2023 15:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a3ca1135-d278-45a4-b872-3428a507f33a
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@digiwand digiwand self-requested a review December 14, 2023 22:25
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e4be2dc) 39.39% compared to head (e41e934) 39.39%.

Files Patch % Lines
...ents/Views/Settings/ExperimentalSettings/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8088      +/-   ##
==========================================
- Coverage   39.39%   39.39%   -0.01%     
==========================================
  Files        1220     1220              
  Lines       29800    29801       +1     
  Branches     2831     2831              
==========================================
  Hits        11740    11740              
- Misses      17371    17372       +1     
  Partials      689      689              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 18, 2023

@jpuri jpuri merged commit c4b18ed into main Dec 18, 2023
26 checks passed
@jpuri jpuri deleted the blcokaid_setting_metrics_fix branch December 18, 2023 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 18, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 18, 2023
@gauthierpetetin gauthierpetetin added release-7.14.0 Issue or pull request that will be included in release 7.14.0 and removed release-7.15.0 Issue or pull request that will be included in release 7.15.0 labels Jan 2, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.14.0 on PR. Adding release label release-7.14.0 on PR and removing other release labels(release-7.15.0), as PR was added to branch 7.14.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Disabling Blockaid from Settings does not fire a metrics event
7 participants