-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Remove using PACKAGE_READ_TOKEN for core preview builds #8089
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8089 +/- ##
=======================================
Coverage 39.61% 39.61%
=======================================
Files 1233 1233
Lines 29830 29830
Branches 2840 2840
=======================================
Hits 11816 11816
Misses 17321 17321
Partials 693 693 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/20054aca-1517-4825-8e35-383a6fb0d181 |
ee37b47
to
9d0d0e2
Compare
6481e06
to
97d3a47
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/64edb9a5-f1b4-4471-885f-9ce2f23c6fa6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR removes the need for the
PACKAGE_READ_TOKEN
in Bitrise CI. According to Mark, it was used to support the older version of preview builds, which used GitHub's registry and required authentication. But we have since switched to using npm for preview builds, so no special authentication is needed.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist