Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove using PACKAGE_READ_TOKEN for core preview builds #8089

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Dec 13, 2023

Description

This PR removes the need for the PACKAGE_READ_TOKEN in Bitrise CI. According to Mark, it was used to support the older version of preview builds, which used GitHub's registry and required authentication. But we have since switched to using npm for preview builds, so no special authentication is needed.

Related issues

Fixes:

Manual testing steps

  • Check that E2E smoke tests still works
  • Check that QA builds still works

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner December 13, 2023 18:19
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97d3a47) 39.61% compared to head (3ad0d94) 39.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8089   +/-   ##
=======================================
  Coverage   39.61%   39.61%           
=======================================
  Files        1233     1233           
  Lines       29830    29830           
  Branches     2840     2840           
=======================================
  Hits        11816    11816           
  Misses      17321    17321           
  Partials      693      693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/20054aca-1517-4825-8e35-383a6fb0d181
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@Cal-L Cal-L force-pushed the ci/remove-preview-builds-step branch from ee37b47 to 9d0d0e2 Compare December 14, 2023 17:56
@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 4, 2024
@Cal-L Cal-L closed this Jan 4, 2024
@Cal-L Cal-L force-pushed the ci/remove-preview-builds-step branch from 6481e06 to 97d3a47 Compare January 4, 2024 00:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
@Cal-L Cal-L reopened this Jan 4, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Jan 4, 2024
@Cal-L
Copy link
Contributor Author

Cal-L commented Jan 4, 2024

@github-actions github-actions bot unlocked this conversation Jan 4, 2024
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MetaMask MetaMask deleted a comment from github-actions bot Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/64edb9a5-f1b4-4471-885f-9ce2f23c6fa6
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@Cal-L Cal-L added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Jan 4, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 0bd8438 into main Jan 4, 2024
56 checks passed
@Cal-L Cal-L deleted the ci/remove-preview-builds-step branch January 4, 2024 20:28
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants