-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramp): keep region always up to date #8097
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8097 +/- ##
==========================================
- Coverage 39.56% 39.56% -0.01%
==========================================
Files 1231 1231
Lines 29818 29821 +3
Branches 2839 2841 +2
==========================================
Hits 11798 11798
- Misses 17324 17329 +5
+ Partials 696 694 -2 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ec1314c2-d297-400e-9f7e-5f32a0c8906f |
@wachunei I finished verifying the buy and sell flows ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
This PR adds a small change to update the locally persisted Region object if the most recent object from the SDK has changed.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist