Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): keep region always up to date #8097

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

wachunei
Copy link
Member

Description

This PR adds a small change to update the locally persisted Region object if the most recent object from the SDK has changed.

Related issues

Fixes:

Manual testing steps

  1. Go through the buy or sell flow without changes

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Dec 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (aa5e8b9) 39.56% compared to head (ed00259) 39.56%.

Files Patch % Lines
app/components/UI/Ramp/buy/hooks/useRegions.ts 0.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8097      +/-   ##
==========================================
- Coverage   39.56%   39.56%   -0.01%     
==========================================
  Files        1231     1231              
  Lines       29818    29821       +3     
  Branches     2839     2841       +2     
==========================================
  Hits        11798    11798              
- Misses      17324    17329       +5     
+ Partials      696      694       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei marked this pull request as ready for review December 14, 2023 20:24
@wachunei wachunei requested a review from a team as a code owner December 14, 2023 20:24
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ec1314c2-d297-400e-9f7e-5f32a0c8906f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@bkirb
Copy link
Contributor

bkirb commented Dec 15, 2023

@wachunei I finished verifying the buy and sell flows ✅

@wachunei wachunei removed the needs-ramp-qa Tickets that need feature QA on the ramps flows label Dec 15, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 19, 2023
Copy link

sonarcloud bot commented Dec 19, 2023

@wachunei wachunei merged commit 6438989 into main Dec 19, 2023
26 checks passed
@wachunei wachunei deleted the feat/ramp-region-updated branch December 19, 2023 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants