chore: Added deprecation notice to non-ds icons

[brianacnguyen]

Description

• Added deprecation notice to non-ds icons, which includes Ionicons, FontAwesome, FontAwesome5, AntDesign, MaterialCommunityIcons, Feather, EvilIcons, SimpleLineIcons, MaterialIcons, Octicons, Entypo, Foundation, Fontisto, and Zocial

Related issues

Fixes: N/A

Manual testing steps

1. Pull this branch and open VS Code
2. Search <IonicIcon
3. Find instance and hover mouse over tag
4. See deprecation notice
5. Repeat for: <FontAwesomeIcon, <AntDesignIcon, <MaterialCommunityIcons, <MaterialIcons, <SimpleLineIcons, FontAwesome5, OcticonsIcon, Entypo, FoundationIcon

Screenshots/Recordings

N/A

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9884203) 39.39% compared to head (159627c) 39.39%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8124   +/-   ##
=======================================
  Coverage   39.39%   39.39%           
=======================================
  Files        1220     1220           
  Lines       29800    29800           
  Branches     2831     2831           
=======================================
  Hits        11740    11740           
  Misses      17371    17371           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[georgewrmarshall]

LGTM! I added manual testing steps and some screenshots