Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ramp): change settings title to buy & sell #8131

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Dec 15, 2023

Description

This PR changes the Settings title for Ramp from "Buy" to "Buy & Sell" and adds tests for this view

Related issues

Fixes:

Manual testing steps

  1. Go to Settings
  2. Confirm the title change

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Dec 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (445ef2b) 39.65% compared to head (8e4b121) 39.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8131      +/-   ##
==========================================
+ Coverage   39.65%   39.83%   +0.18%     
==========================================
  Files        1233     1233              
  Lines       29820    29820              
  Branches     2840     2840              
==========================================
+ Hits        11824    11879      +55     
+ Misses      17307    17252      -55     
  Partials      689      689              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei marked this pull request as ready for review December 16, 2023 18:32
@wachunei wachunei requested a review from a team as a code owner December 16, 2023 18:32
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f2956eec-9147-4d5c-be36-4a74408aa859
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 19, 2023
@bkirb
Copy link
Contributor

bkirb commented Jan 9, 2024

@wachunei LGTM I verified this change ✅

@wachunei wachunei removed the needs-ramp-qa Tickets that need feature QA on the ramps flows label Jan 9, 2024
@wachunei
Copy link
Member Author

wachunei commented Jan 9, 2024

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wachunei wachunei merged commit 7ad3bb4 into main Jan 9, 2024
26 checks passed
@wachunei wachunei deleted the feat/ramp-settings-title branch January 9, 2024 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants