-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ramp): change settings title to buy & sell #8131
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8131 +/- ##
==========================================
+ Coverage 39.65% 39.83% +0.18%
==========================================
Files 1233 1233
Lines 29820 29820
Branches 2840 2840
==========================================
+ Hits 11824 11879 +55
+ Misses 17307 17252 -55
Partials 689 689 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f2956eec-9147-4d5c-be36-4a74408aa859 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wachunei LGTM I verified this change ✅ |
|
Description
This PR changes the Settings title for Ramp from "Buy" to "Buy & Sell" and adds tests for this view
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist