Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ramp): use patched gradle for react native payments #8133

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

wachunei
Copy link
Member

Description

This PR patches the build.gradle file of our current fork of react-native-payments. The patch updates dependencies that are going to be blocking requirements for new releases

Related issues

Fixes: #7697

Manual testing steps

  1. The app should not present any regressions

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E labels Dec 15, 2023
@wachunei wachunei marked this pull request as ready for review December 15, 2023 19:46
@wachunei wachunei requested a review from a team as a code owner December 15, 2023 19:46
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/05450b2b-7bc4-47c7-9ac3-e325057adb38
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/65769e73-1457-4c96-bef1-16c2c55cc310
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1325ad) 39.65% compared to head (3318b97) 39.65%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8133   +/-   ##
=======================================
  Coverage   39.65%   39.65%           
=======================================
  Files        1233     1233           
  Lines       29820    29820           
  Branches     2840     2840           
=======================================
  Hits        11824    11824           
  Misses      17307    17307           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 16, 2023
Copy link
Contributor

github-actions bot commented Jan 8, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/77ffb9d9-c49f-4fa9-94a6-942780c6359d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sethkfman sethkfman added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ce608fde-3375-489b-b7ad-cc8f8feed8eb
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sethkfman sethkfman removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-ramp-qa Tickets that need feature QA on the ramps flows labels Jan 9, 2024
@wachunei wachunei merged commit 46a8774 into main Jan 9, 2024
28 of 31 checks passed
@wachunei wachunei deleted the chore/ramp-patch-react-native-payments branch January 9, 2024 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Google Play dependency
4 participants