Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support token detection on linea #8171

Merged
merged 9 commits into from
Jan 21, 2024

Conversation

bergeron
Copy link
Contributor

Description

Enables token autodetection on Linea

Related issues

Manual testing steps

  1. Restore a wallet containing tokens (like WETH, USDC) on Linea
  2. Tokens should be automatically detected and suggested for import (N new tokens found in this account)
  3. Click Import tokens to manually import
  4. There should be a search box that suggests tokens as you type their symbols

Screenshots/Recordings

Before

Screen.Recording.2023-12-19.at.3.12.09.PM.mov

After

Screen.Recording.2023-12-19.at.2.58.14.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner December 19, 2023 21:18
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the title support token detection on linea feat: Support token detection on linea Dec 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (699ff9f) 40.30% compared to head (995dc50) 40.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8171   +/-   ##
=======================================
  Coverage   40.30%   40.30%           
=======================================
  Files        1235     1235           
  Lines       29928    29928           
  Branches     2872     2872           
=======================================
  Hits        12062    12062           
  Misses      17173    17173           
  Partials      693      693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3c3092b3-6313-4b73-a271-941fbdbfdba1
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Cal-L
Cal-L previously approved these changes Dec 21, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. what is that yellow box error though?

@Cal-L Cal-L added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Dec 21, 2023
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 5, 2024
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bergeron. I'm am not able to load asset balances on Linea Mainnet on my android emulator. Can you take a look?
https://recordit.co/VKuFxuwyMy

@chrisleewilcox chrisleewilcox added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Jan 8, 2024
@bergeron
Copy link
Contributor Author

Fixed missing prices in e02095a, here's the before/after:

image

@metamaskbot metamaskbot added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed blocked labels Jan 19, 2024
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jan 19, 2024
@chrisleewilcox chrisleewilcox removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jan 21, 2024
Copy link

sonarcloud bot commented Jan 21, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jan 21, 2024
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisleewilcox chrisleewilcox merged commit 487f25d into main Jan 21, 2024
32 checks passed
@chrisleewilcox chrisleewilcox deleted the brian/linea-token-detection branch January 21, 2024 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-assets team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants