-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support token detection on linea #8171
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8171 +/- ##
=======================================
Coverage 40.30% 40.30%
=======================================
Files 1235 1235
Lines 29928 29928
Branches 2872 2872
=======================================
Hits 12062 12062
Misses 17173 17173
Partials 693 693 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3c3092b3-6313-4b73-a271-941fbdbfdba1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. what is that yellow box error though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bergeron. I'm am not able to load asset balances on Linea Mainnet on my android emulator. Can you take a look?
https://recordit.co/VKuFxuwyMy
…/linea-token-detection
…/linea-token-detection
…/linea-token-detection
Fixed missing prices in e02095a, here's the before/after: |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Enables token autodetection on Linea
Related issues
Manual testing steps
N new tokens found in this account
)Import tokens
to manually importScreenshots/Recordings
Before
Screen.Recording.2023-12-19.at.3.12.09.PM.mov
After
Screen.Recording.2023-12-19.at.2.58.14.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist