Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to unable to find conversion rate when failing to get conversion rate #8184

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Dec 21, 2023

Description

Currently we are displaying "unable to load balance" whenever the app is not able to get conversion rates for an asset. To be more accurate we should update the message to say "unable to find conversion rate" for this scenario.

Related issues

Fixes: #8151

Manual testing steps

  1. Go to the wallet view
  2. import uniswap token in sepolia testnet
  3. app is not able to retrieve conversion rate
  4. "unable to load conversion rates" should be displayed (FAILED: "unable to load balance" is displayed)

Screenshots/Recordings

Before

before

After

after

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead team-assets labels Dec 21, 2023
@salimtb salimtb requested a review from a team as a code owner December 21, 2023 12:45
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3679f453-e69b-444c-b8d5-2fa79ed1918a
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@salimtb salimtb requested a review from Cal-L December 21, 2023 12:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1271ef) 39.56% compared to head (d82db03) 39.60%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8184      +/-   ##
==========================================
+ Coverage   39.56%   39.60%   +0.04%     
==========================================
  Files        1231     1232       +1     
  Lines       29821    29826       +5     
  Branches     2841     2841              
==========================================
+ Hits        11800    11814      +14     
+ Misses      17327    17322       -5     
+ Partials      694      690       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I kicked off E2E one more time.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/61aef386-2d0e-4a63-9803-b5c89d0258bf
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Jan 4, 2024

@Andepande Andepande added the QA Passed A successful QA run through has been done label Jan 4, 2024
@salimtb salimtb merged commit b2c9d98 into main Jan 5, 2024
28 checks passed
@salimtb salimtb deleted the fix/update-error-message branch January 5, 2024 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 5, 2024
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-assets team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Token List: update to "unable to find conversion rate" when failing to get conversion rate
5 participants