Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 8187 remove drawer folder e2e folder #8197

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

SamuelSalas
Copy link
Member

@SamuelSalas SamuelSalas commented Dec 28, 2023

Description

In the Pages folder from e2e, the drawer folder still exists. The folder is outdated and does not longer reflects the current behavior from the app. There should be a reorganization of the files inside to their respective location.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Smoke Test runs: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1c1e7402-de02-455b-b2cb-4d19ee44cfc0
Regression Test runs: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27e73c04-c820-4e89-b36f-739692fbe2d4

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas self-assigned this Dec 28, 2023
@SamuelSalas SamuelSalas requested a review from a team as a code owner December 28, 2023 17:02
@SamuelSalas SamuelSalas linked an issue Dec 28, 2023 that may be closed by this pull request
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelSalas SamuelSalas merged commit 483b367 into main Dec 28, 2023
32 checks passed
@SamuelSalas SamuelSalas deleted the test/8187-remove-drawer-folder-e2e-folder branch December 28, 2023 20:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Drawer folder from e2e folder
5 participants