-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: onboarding folder refactor page objects #8200
test: onboarding folder refactor page objects #8200
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8200 +/- ##
=======================================
Coverage 39.65% 39.65%
=======================================
Files 1233 1233
Lines 29820 29820
Branches 2840 2840
=======================================
Hits 11824 11824
Misses 17307 17307
Partials 689 689 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamuelSalas can you update this branch with main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ✅ ✅ ✅
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
We are aiming to refactor the page objects in the onboarding folder so that they strictly follow the page object model pattern. This would aide in providing more readable and help standardize the way we create our tests.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Smoke Test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/76c13c30-b501-49da-a252-ba3e759e6067
Regression Test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6dc36247-ef73-42e8-a5ef-be4c942ccd9c
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist