fix: Isolate logic to expose js env variables sooner

[tommasini]

Description

When creating a new terminal and trying to run any of the building commands like yarn setup yarn watch yarn start:android and yarn start:ios

It would give an error that the environment variables are not loaded

The problem was that we were checking if the variables were loaded before they were actually loaded.

The solution is to load the variables as one of the first steps if they exist.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[owencraston]

This is a good solution but I am wondering if we should have better defaults for these env variables? I know that for METAMASK_BUILD_TYPE we can default to main and METAMASK_ENVIRONMENT should probably be local? Then in the build.sh we can simply just have check if these values exist and if not use these defaults?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (487f25d) 40.30% compared to head (532ba68) 40.30%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8202   +/-   ##
=======================================
  Coverage   40.30%   40.30%           
=======================================
  Files        1235     1235           
  Lines       29928    29928           
  Branches     2872     2872           
=======================================
  Hits        12062    12062           
  Misses      17173    17173           
  Partials      693      693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[sethkfman]

LGTM