Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update blockaid dependency to latest version #8204

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 4, 2024

Description

Update blockaid dependency to 1.4.0

Related issues

Fixes: MetaMask/MetaMask-planning#1849

Manual testing steps

  1. Go to test dapp
  2. Submit a malicious transaction
  3. It should show blockaid error message as expected

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E labels Jan 4, 2024
@jpuri jpuri requested a review from a team as a code owner January 4, 2024 15:39
Copy link
Contributor

github-actions bot commented Jan 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title Update blockaid dependency to latest version feature: update blockaid dependency to latest version Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e1ad3c7-afa3-41a2-8815-939ec6390d3d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jpuri jpuri changed the title feature: update blockaid dependency to latest version feat: update blockaid dependency to latest version Jan 5, 2024
@jpuri jpuri merged commit e553e82 into main Jan 11, 2024
37 of 39 checks passed
@jpuri jpuri deleted the ppom_update_1.4.0 branch January 11, 2024 14:13
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants