Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update copy from seed to secret recovery phrase #8207

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

gantunesr
Copy link
Member

Description

During onboarding, there's a view that uses the title "Import from seed", this change updates the title to "Import from Secret Recovery Phrase".

Related issues

Fixes: X

Manual testing steps

  1. Start onboarding
  2. Go to "Import using Secret Recovery Phrase"
  3. Notice the title is updated

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-accounts labels Jan 5, 2024
@gantunesr gantunesr marked this pull request as ready for review January 5, 2024 13:43
@gantunesr gantunesr requested a review from a team as a code owner January 5, 2024 13:43
Copy link
Contributor

github-actions bot commented Jan 5, 2024

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f451ff6-5216-42f0-961d-e4903acec1c6
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2c9d98) 39.64% compared to head (d556052) 39.64%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8207   +/-   ##
=======================================
  Coverage   39.64%   39.64%           
=======================================
  Files        1233     1233           
  Lines       29830    29830           
  Branches     2840     2840           
=======================================
  Hits        11826    11826           
  Misses      17315    17315           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 5, 2024
@gantunesr gantunesr merged commit 2b409a5 into main Jan 5, 2024
37 checks passed
@gantunesr gantunesr deleted the fix/import-from-srp-title branch January 5, 2024 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 5, 2024
@angelcheung22 angelcheung22 added this to the Q1 2024 milestone Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants