-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Android sdk dapp icon support #8215
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8215 +/- ##
=======================================
Coverage 39.83% 39.83%
=======================================
Files 1233 1233
Lines 29820 29820
Branches 2840 2840
=======================================
Hits 11879 11879
Misses 17252 17252
Partials 689 689 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR sets the client icon from the originator on the Android SDK's
AndroidService
so that the icon of the dapp connecting to the wallet can be displayedRelated issues
Fixes: N/A
Manual testing steps
Make a connection to the wallet from the Android SKD test dapp. When the connection request prompt shows up the dapp icon should be visible
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist