Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Android sdk dapp icon support #8215

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

elefantel
Copy link
Contributor

@elefantel elefantel commented Jan 8, 2024

Description

This PR sets the client icon from the originator on the Android SDK's AndroidService so that the icon of the dapp connecting to the wallet can be displayed

Related issues

Fixes: N/A

Manual testing steps

Make a connection to the wallet from the Android SKD test dapp. When the connection request prompt shows up the dapp icon should be visible

Screenshots/Recordings

dapp-icon

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@elefantel elefantel requested a review from a team as a code owner January 8, 2024 10:32
Copy link
Contributor

github-actions bot commented Jan 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@elefantel elefantel added the team-sdk SDK team label Jan 8, 2024
@elefantel elefantel changed the title Android sdk dapp icon support feat: Android sdk dapp icon support Jan 8, 2024
@christopherferreira9 christopherferreira9 added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ad3bb4) 39.83% compared to head (2189ba2) 39.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8215   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files        1233     1233           
  Lines       29820    29820           
  Branches     2840     2840           
=======================================
  Hits        11879    11879           
  Misses      17252    17252           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elefantel elefantel merged commit fd2e917 into main Jan 10, 2024
26 checks passed
@elefantel elefantel deleted the android-sdk-dapp-icon-support branch January 10, 2024 08:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 10, 2024
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants