Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct link for reporting false positives in blockaid banner #8216

Merged
merged 31 commits into from
Jan 22, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 8, 2024

Description

Fix the link used for reporting false positives on blockaid banner and also pass more data to it.

Related issues

Fixes: MetaMask/MetaMask-planning#1697

Manual testing steps

  1. Enables blockaid in mobile app
  2. Go to test dapp and submit malicious transaction
  3. Click "Report the issue" link. It should open in right site with data prefilled.

Screenshots/Recordings

Screen.Recording.2024-01-08.at.8.54.18.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner January 8, 2024 15:21
Copy link
Contributor

github-actions bot commented Jan 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Jan 8, 2024
@jpuri jpuri changed the title Fix: use correct link for reporting false positives in blockaid banner fix: use correct link for reporting false positives in blockaid banner Jan 8, 2024
Copy link

socket-security bot commented Jan 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/envinfo@7.11.0 environment, eval, filesystem, shell 0 162 kB tabrindle
npm/react-native-gzip@1.1.0 Transitive: environment, eval, filesystem, network, shell, unsafe +387 150 MB ammarahm-ed

View full report↗︎

Copy link

socket-security bot commented Jan 8, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/deprecated-react-native-prop-types@3.0.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@jpuri
Copy link
Contributor Author

jpuri commented Jan 9, 2024

@SocketSecurity ignore react-native-gzip@1.1.0
@SocketSecurity ignore deprecated-react-native-prop-types@3.0.2

ppom/package.json Outdated Show resolved Hide resolved
ios/MetaMask.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
app/constants/network.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (17b741e) 40.21% compared to head (ce40a6e) 40.24%.

Files Patch % Lines
...pp/components/UI/BlockaidBanner/BlockaidBanner.tsx 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8216      +/-   ##
==========================================
+ Coverage   40.21%   40.24%   +0.02%     
==========================================
  Files        1235     1235              
  Lines       29883    29900      +17     
  Branches     2862     2865       +3     
==========================================
+ Hits        12018    12032      +14     
- Misses      17174    17175       +1     
- Partials      691      693       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Show resolved Hide resolved
segun
segun previously approved these changes Jan 16, 2024
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit. LGTM

@jpuri
Copy link
Contributor Author

jpuri commented Jan 22, 2024

@SocketSecurity ignore npm/deprecated-react-native-prop-types@3.0.2

Copy link

sonarcloud bot commented Jan 22, 2024

@jpuri
Copy link
Contributor Author

jpuri commented Jan 22, 2024

@jpuri jpuri merged commit 3401cf8 into main Jan 22, 2024
26 checks passed
@jpuri jpuri deleted the false_link_data branch January 22, 2024 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 22, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants