-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fixed Swap smoke and regression test failures #8217
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8217 +/- ##
=======================================
Coverage 39.83% 39.83%
=======================================
Files 1233 1233
Lines 29820 29820
Branches 2840 2840
=======================================
Hits 11879 11879
Misses 17252 17252
Partials 689 689 ☔ View full report in Codecov by Sentry. |
1842418
to
f6f61e1
Compare
f6f61e1
to
9a3ad05
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixed Swap smoke and regression test failures when running on Android.
Please check the runs I did on Bitrise with the fixes
Smoke: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b22e161-3732-4748-9193-771a3a7ad5a5
Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e0e0ebf-e127-406d-b350-1c535b0ecf29
Related issues
Manual testing steps
Run this script
yarn test:e2e:android:debug:single e2e/specs/swaps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist