Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixed Swap smoke and regression test failures #8217

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

davibroc
Copy link
Contributor

@davibroc davibroc commented Jan 8, 2024

Description

Fixed Swap smoke and regression test failures when running on Android.

Please check the runs I did on Bitrise with the fixes
Smoke: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b22e161-3732-4748-9193-771a3a7ad5a5
Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e0e0ebf-e127-406d-b350-1c535b0ecf29

Related issues

Manual testing steps

Run this script yarn test:e2e:android:debug:single e2e/specs/swaps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@davibroc davibroc requested a review from a team as a code owner January 8, 2024 16:27
Copy link
Contributor

github-actions bot commented Jan 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davibroc davibroc changed the title Fixed timing issue test: fixed timing issue Jan 8, 2024
@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Jan 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e478c1) 39.83% compared to head (9a3ad05) 39.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8217   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files        1233     1233           
  Lines       29820    29820           
  Branches     2840     2840           
=======================================
  Hits        11879    11879           
  Misses      17252    17252           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davibroc davibroc force-pushed the fix/swap-test-android-failure branch from 1842418 to f6f61e1 Compare January 10, 2024 19:11
@davibroc davibroc changed the title test: fixed timing issue test: fixed Swap smoke and regression test failures Jan 11, 2024
@davibroc davibroc force-pushed the fix/swap-test-android-failure branch from f6f61e1 to 9a3ad05 Compare January 11, 2024 05:52
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davibroc davibroc merged commit 7f9909a into main Jan 11, 2024
26 checks passed
@davibroc davibroc deleted the fix/swap-test-android-failure branch January 11, 2024 07:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E No QA Needed Apply this label when your PR does not need any QA effort. release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants