test: 1328 refactor modals page batch 1

[SamuelSalas]

Description

We are aiming to refactor the page objects in the modal folder so that they strictly follow the page object model pattern. This would aide in providing more readable and help standardize the way we create our tests. Because of the amount of files inside of the modal folder, the scope was divided into a batch of 4.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Smoke Test Run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/088817e8-3e64-4843-8962-8e7b329008c9
Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/169abada-eadc-4f32-ac11-0fde6ca3bc58

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb51857) 39.83% compared to head (33a180c) 39.83%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8231   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files        1233     1233           
  Lines       29821    29821           
  Branches     2840     2840           
=======================================
  Hits        11880    11880           
  Misses      17252    17252           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[cortisiko]

LGTM