Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enabling blockaid should be possible only if user is on mainnet #8233

Merged
merged 11 commits into from
Jan 11, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 10, 2024

Description

User should be able to enable blockaid only on mainnet.

Related issues

Fixes:

Manual testing steps

  1. Open the application
  2. Select Goreli network
  3. Go to settings, it should not be possible to enable blockaid

Screenshots/Recordings

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • [] I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri marked this pull request as ready for review January 10, 2024 17:22
@jpuri jpuri requested a review from a team as a code owner January 10, 2024 17:22
@jpuri jpuri changed the title Update fix: enabling blockaid should be possible only if user is on mainnet Jan 10, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7a3ac2c1-9dcf-4d48-a6fb-88fcdeef7614
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Jan 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd2e917) 39.83% compared to head (b0ca9b5) 39.83%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8233   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files        1233     1233           
  Lines       29820    29821    +1     
  Branches     2840     2840           
=======================================
+ Hits        11879    11880    +1     
  Misses      17252    17252           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

segun
segun previously approved these changes Jan 10, 2024
locales/languages/en.json Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jan 11, 2024

@jpuri jpuri merged commit eb51857 into main Jan 11, 2024
26 of 28 checks passed
@jpuri jpuri deleted the blockaid_init_fix branch January 11, 2024 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 11, 2024
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants