Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Price API perf improvements #8235

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: Price API perf improvements #8235

merged 1 commit into from
Jan 10, 2024

Conversation

bergeron
Copy link
Contributor

Description

Patches batching and sorting changes to improve price API perf (MetaMask/core#3753)

Related issues

Manual testing steps

Token fiat prices should still appear on home page

Screenshots/Recordings

No visible changes

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner January 10, 2024 16:17
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the title Price API perf improvements Fix: Price API perf improvements Jan 10, 2024
@bergeron bergeron changed the title Fix: Price API perf improvements fix: Price API perf improvements Jan 10, 2024
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd2e917) 39.83% compared to head (210c4a3) 39.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8235   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files        1233     1233           
  Lines       29820    29820           
  Branches     2840     2840           
=======================================
  Hits        11879    11879           
  Misses      17252    17252           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman added Run Smoke E2E release-7.15.0 Issue or pull request that will be included in release 7.15.0 labels Jan 10, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0d15a7a-0f25-48f3-ae86-22ba7c3a0ea6
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, LGTM! Thanks!

@bergeron bergeron merged commit 3a3b066 into main Jan 10, 2024
36 of 39 checks passed
@bergeron bergeron deleted the brian/price-api-perf branch January 10, 2024 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants