test: Fix Swap Smoke tests failures

[davibroc]

Description

The problem with these tests is that we check for the Swap to complete we wait for this pop up message to appear Swap complete ETH to DAI so we call checkIfElementByTextIsVisible which has a timeout of 25 secs. However sometime, depending on network conditions, it can take longer and that’s what causes the flakiness. Right now the 25 secs is hardcoded in checkIfElementByTextIsVisible. I changed the parameter to be optional so I can pass 60 secs which should be enough for the Swap to complete.

I also changed some the Swap from the token chart test to be a regression not a smoke as it's uncommon
and added token chart display test as smoke test

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07cec0a) 39.83% compared to head (43525ab) 40.21%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8254      +/-   ##
==========================================
+ Coverage   39.83%   40.21%   +0.37%     
==========================================
  Files        1233     1234       +1     
  Lines       29821    29883      +62     
  Branches     2840     2862      +22     
==========================================
+ Hits        11880    12017     +137     
+ Misses      17252    17175      -77     
- Partials      689      691       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cortisiko]

do not forget to run bitrise.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[cortisiko]

Looks good