Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added temp brand tokens to mobile codebase #8255

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Added white and black brand color to be used for elements that need absolute white/black color regardless of theme

Related issues

Fixes: N/A

Manual testing steps

  1. N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Jan 11, 2024
@brianacnguyen brianacnguyen self-assigned this Jan 11, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner January 11, 2024 17:57
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen changed the title [feat] Added temp brand tokens to mobile codebase feat: Added temp brand tokens to mobile codebase Jan 11, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Those should align with the design tokens once we move them to the package. Left one comment regarding the square bracket key syntax

app/util/theme/temp-tokens/brandColors.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jan 12, 2024

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 🚀

@brianacnguyen brianacnguyen merged commit edae40e into main Jan 12, 2024
26 checks passed
@brianacnguyen brianacnguyen deleted the nohex/temp-tokens branch January 12, 2024 18:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 12, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants