Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds snapController selector and initial state #8272

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR fixes a problem happening when accessing snaps initial store (undefined), leading to crash in mobile app.

Related issues

Fixes:

N/A

Manual testing steps

  1. Go to settings page
  2. Click on snaps option

Screenshots/Recordings

Before

Screen.Recording.2024-01-12.at.18.30.36.mov

After

Screen.Recording.2024-01-12.at.18.31.37.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer requested a review from a team as a code owner January 12, 2024 21:39
@Jonathansoufer Jonathansoufer self-assigned this Jan 12, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jonathansoufer Jonathansoufer merged commit 86947db into main Jan 12, 2024
26 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/add-snap-selector-to-redux branch January 12, 2024 22:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants