Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Network Settings Actionable Buttons to use DS buttons #8287

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jan 16, 2024

Description

  • Update Network Settings Actionable Buttons to use DS buttons

Related issues

Fixes: #8336

Manual testing steps

  1. Go to Settings
  2. Click on Network
  3. Click on Add Network
  4. Click on Custom

Screenshots/Recordings

Before

Simulator Screenshot - iPhone 15 Pro - 2024-01-15 at 16 20 01
Simulator Screenshot - iPhone 15 Pro - 2024-01-15 at 16 28 07

After

Simulator Screenshot - iPhone 15 Pro - 2024-01-15 at 16 28 24
Simulator Screenshot - iPhone 15 Pro - 2024-01-15 at 16 28 39

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen requested a review from a team as a code owner January 16, 2024 04:07
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64b7cb5) 39.83% compared to head (a2750f0) 40.20%.
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8287      +/-   ##
==========================================
+ Coverage   39.83%   40.20%   +0.37%     
==========================================
  Files        1233     1235       +2     
  Lines       29821    29926     +105     
  Branches     2840     2872      +32     
==========================================
+ Hits        11880    12033     +153     
+ Misses      17252    17200      -52     
- Partials      689      693       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianacnguyen brianacnguyen self-assigned this Jan 18, 2024
@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Jan 18, 2024
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianacnguyen brianacnguyen merged commit 0a0237e into main Jan 24, 2024
34 checks passed
@brianacnguyen brianacnguyen deleted the nohex/settings branch January 24, 2024 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 24, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MOB] Update Network Settings Actionable Buttons to use DS buttons
4 participants