Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update walletconnect se-sdk to 1.7.0 #8290

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Jan 16, 2024

Description

Library updated to latest version.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@abretonc7s abretonc7s requested a review from a team as a code owner January 16, 2024 12:09
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk SDK team labels Jan 16, 2024
Copy link

socket-security bot commented Jan 16, 2024

Copy link

socket-security bot commented Jan 16, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@ioredis/commands@1.2.0, npm/@parcel/watcher-android-arm64@2.3.0, npm/@parcel/watcher-darwin-arm64@2.3.0, npm/@parcel/watcher-darwin-x64@2.3.0, npm/@parcel/watcher-freebsd-x64@2.3.0, npm/@parcel/watcher-linux-arm-glibc@2.3.0, npm/@parcel/watcher-linux-arm64-glibc@2.3.0, npm/@parcel/watcher-linux-arm64-musl@2.3.0, npm/@parcel/watcher-linux-x64-glibc@2.3.0, npm/@parcel/watcher-linux-x64-musl@2.3.0, npm/@parcel/watcher-wasm@2.3.0, npm/@parcel/watcher-win32-arm64@2.3.0, npm/@parcel/watcher-win32-ia32@2.3.0, npm/@parcel/watcher-win32-x64@2.3.0, npm/@parcel/watcher@2.3.0, npm/@walletconnect/auth-client@2.1.2, npm/@walletconnect/core@2.11.0, npm/@walletconnect/jsonrpc-ws-connection@1.0.14, npm/@walletconnect/keyvaluestorage@1.1.1, npm/@walletconnect/react-native-compat@2.11.0, npm/@walletconnect/se-sdk@1.7.0, npm/@walletconnect/sign-client@2.11.0, npm/@walletconnect/types@2.11.0, npm/@walletconnect/utils@2.11.0, npm/@walletconnect/web3wallet@1.10.0, npm/anymatch@3.1.3, npm/arch@2.2.0, npm/citty@0.1.5, npm/clipboardy@3.0.0, npm/cluster-key-slot@1.1.2, npm/consola@3.2.3, npm/cookie-es@1.0.0, npm/defu@6.1.3, npm/denque@2.1.0, npm/destr@2.0.2, npm/get-port-please@3.1.1, npm/h3@1.9.0, npm/http-shutdown@1.2.2, npm/idb-keyval@6.2.1, npm/ioredis@5.3.2, npm/iron-webcrypto@1.0.0, npm/jiti@1.21.0, npm/jsonc-parser@3.2.0, npm/listhen@1.5.5, npm/lodash.isarguments@3.1.0, npm/lru-cache@10.1.0, npm/micromatch@4.0.5, npm/mime@3.0.0, npm/mlly@1.4.2, npm/mri@1.2.0, npm/napi-wasm@1.1.0, npm/node-addon-api@7.0.0, npm/node-fetch-native@1.6.1, npm/node-forge@1.3.1, npm/ofetch@1.3.3, npm/pathe@1.1.1, npm/pkg-types@1.0.3, npm/radix3@1.1.0, npm/react-native-url-polyfill@2.0.0, npm/redis-errors@1.2.0, npm/redis-parser@3.0.0, npm/standard-as-callback@2.1.0, npm/std-env@3.7.0, npm/ufo@1.3.2, npm/uncrypto@0.1.3, npm/unenv@1.8.0, npm/unstorage@1.10.1, npm/untun@0.1.3, npm/uqr@0.1.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

omridan159
omridan159 previously approved these changes Jan 16, 2024
@abretonc7s
Copy link
Contributor Author

@SocketSecurity ignore-all

@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 16, 2024
@christopherferreira9
Copy link
Contributor

Platforms: iOS and Android

Checks:

  • Connect & Sign via QR Code
  • COnnect & Sign via deeplink

Dapps:
https://feba4b8b.web3modal-dev.pages.dev/v2Customised
https://release-2-3-0.web3modal-dev.pages.dev/v2Base

@christopherferreira9
Copy link
Contributor

Issue 1: Can't connect to WC dapps
Steps:

  1. Go to to https://release-2-3-0.web3modal-dev.pages.dev/v2Extended
  2. Click connect on the web dapp
  3. Scan the QR code -> See issue
Screen.Recording.2024-01-16.at.14.57.12.mov

Logs:

 ERROR  {"context": "client"} this.client.core.relayer.confirmOnlineStateOrThrow is not a function. (In 'this.client.core.relayer.confirmOnlineStateOrThrow()', 'this.client.core.relayer.confirmOnlineStateOrThrow' is undefined)
 ERROR  invalid wallet status [TypeError: this.client.core.relayer.confirmOnlineStateOrThrow is not a function. (In 'this.client.core.relayer.confirmOnlineStateOrThrow()', 'this.client.core.relayer.confirmOnlineStateOrThrow' is undefined)]

@christopherferreira9 christopherferreira9 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Jan 16, 2024
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@christopherferreira9
Copy link
Contributor

QA passed.
Connected via Qr Code and deeplink to https://feba4b8b.web3modal-dev.pages.dev/v2Customised and https://release-2-3-0.web3modal-dev.pages.dev/v2Base with both android and iOS.

@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jan 25, 2024
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 merged commit 0e87d5f into main Jan 25, 2024
28 of 29 checks passed
@christopherferreira9 christopherferreira9 deleted the se-sdk-update branch January 25, 2024 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants