Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixup regex typo for validChainIdHex #8303

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

frankvonhoven
Copy link
Contributor

Description

There was a typo in the regex usage of the validChainIdHex method.

This fixes it from snake case to camel case

Related issues

Fixes: #8302

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-client labels Jan 16, 2024
@frankvonhoven frankvonhoven requested a review from a team as a code owner January 16, 2024 23:19
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added Run Smoke E2E release-7.16.0 Issue or pull request that will be included in release 7.16.0 labels Jan 16, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93a01be6-3e7b-480e-b4b8-649f0011189d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f791282) 40.21% compared to head (819190b) 40.21%.

Files Patch % Lines
...Settings/NetworksSettings/NetworkSettings/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8303   +/-   ##
=======================================
  Coverage   40.21%   40.21%           
=======================================
  Files        1235     1235           
  Lines       29885    29885           
  Branches     2863     2863           
=======================================
  Hits        12018    12018           
  Misses      17176    17176           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 16, 2024

@frankvonhoven frankvonhoven merged commit 3245f78 into main Jan 17, 2024
37 checks passed
@frankvonhoven frankvonhoven deleted the fix/typo-in-regex-method branch January 17, 2024 23:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sentry] [BUG] TypeError: undefined is not an object (evaluating '_r(d[40]).regex.validChainId_hex.test')
4 participants