Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump detox to v20.16 #8304

Merged
merged 4 commits into from
Jan 18, 2024
Merged

test: bump detox to v20.16 #8304

merged 4 commits into from
Jan 18, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Jan 17, 2024

Description

We are over due for a version bump! Detox v20.16 was released a few days ago. The purpose of this PR is to bump the detox version.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Smoke run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/acf63ae1-677b-4fdf-b591-0b3e589e7a43
Regression run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/74d8a22c-3641-48fb-9ef0-a95999240c2b

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-client labels Jan 17, 2024
@cortisiko cortisiko requested a review from a team as a code owner January 17, 2024 02:06
Copy link

socket-security bot commented Jan 17, 2024

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
detox 20.14.3...20.16.0 None +6/-1 9.32 MB wix.mobile

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f791282) 40.21% compared to head (f8a07c8) 40.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8304   +/-   ##
=======================================
  Coverage   40.21%   40.21%           
=======================================
  Files        1235     1235           
  Lines       29885    29885           
  Branches     2863     2863           
=======================================
  Hits        12018    12018           
  Misses      17176    17176           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c7b3cb44-4bc8-4fda-a7c2-3a287ff2daf0
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit a4e018a into main Jan 18, 2024
28 checks passed
@cortisiko cortisiko deleted the detox/bump-to-v20.16.0 branch January 18, 2024 01:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants