fix: cocoapod cache issue

[vinistevam]

Description

This PR aims to fix an issue when run ios build when a dependency is updated. After analysing the latest cases reported facing issues with ios build I realised that cocoapod restore was overwriting the cocoa pod install in the yarn setup step. So, I moved the restore cocoa pod cache on top of the yarn setup step to take advantage of the cache and properly update the new dependencies.

Pipeline error: https://app.bitrise.io/build/8ae57475-c72a-41ce-96f2-d3b6768b9d16
Error:

PhaseScriptExecution [CP]\ Check\ Pods\ Manifest.lock /Users/vagrant/git/ios/build/Build/Intermediates.noindex/MetaMask.build/Debug-iphonesimulator/MetaMask.build/Script-99E9B9D94E374E1799EFBA99.sh (in target 'MetaMask' from project 'MetaMask')
(1 failure)
error Command failed with exit code 65.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1487

Manual testing steps

1. Update a dependency
2. Run smoke pipeline
3. Install cocoapod should run and update the cache

Screenshots/Recordings

Before

Pipeline updating cocoa pod:
https://app.bitrise.io/build/8ae57475-c72a-41ce-96f2-d3b6768b9d16

After

Pipeline updating cocoa pod adding back the cocopod install step:
https://app.bitrise.io/build/8631a2cf-89f7-4025-964f-4c8bfeb4e28c

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6892d1) 40.20% compared to head (8a842c4) 40.20%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8306   +/-   ##
=======================================
  Coverage   40.20%   40.20%           
=======================================
  Files        1235     1235           
  Lines       29926    29926           
  Branches     2872     2872           
=======================================
  Hits        12033    12033           
  Misses      17200    17200           
  Partials      693      693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vinistevam]

pipeline: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e6a9911-3aea-41ca-b50e-64826468993f

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0516007-124a-4beb-ba40-c8305c669c45
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7264e209-ab57-41db-bf18-9d4b7f541d41
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[sethkfman]

LGTM

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud