Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decreased UR density #8319

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: decreased UR density #8319

merged 1 commit into from
Jan 18, 2024

Conversation

gantunesr
Copy link
Member

Description

This PR modifies the density of the animated QR codes so that they can be scanned by the ZERO hardware wallet from NGRAVE.

Original PR: #8300

Related issues

Fixes: NA

Manual testing steps

  1. Connect a QR hardware
  2. Send a Transaction (eg. using the test app at https://metamask.github.io/test-dapp/)
  3. See the QR code

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-hardware-wallets labels Jan 18, 2024
@gantunesr gantunesr requested a review from a team as a code owner January 18, 2024 01:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gantunesr
Copy link
Member Author

This change has already been QA approved by @vivek-consensys. Check #8300 (comment)

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7c944a98-ed6b-499c-9d61-6c868fc0eb75
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@gantunesr gantunesr changed the title feat: decreased UR density (#8300) feat: decreased UR density Jan 18, 2024
Copy link

sonarcloud bot commented Jan 18, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4e018a) 40.21% compared to head (f37e18f) 40.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8319   +/-   ##
=======================================
  Coverage   40.21%   40.21%           
=======================================
  Files        1235     1235           
  Lines       29885    29885           
  Branches     2863     2863           
=======================================
  Hits        12018    12018           
  Misses      17176    17176           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@montelaidev montelaidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested sign transaction and sign typed data with a keystone.

@gantunesr gantunesr merged commit 8752d86 into main Jan 18, 2024
36 checks passed
@gantunesr gantunesr deleted the feat/ngrave-support branch January 18, 2024 09:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 18, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-hardware-wallets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants