-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: decreased UR density #8319
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This change has already been QA approved by @vivek-consensys. Check #8300 (comment) |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7c944a98-ed6b-499c-9d61-6c868fc0eb75 |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8319 +/- ##
=======================================
Coverage 40.21% 40.21%
=======================================
Files 1235 1235
Lines 29885 29885
Branches 2863 2863
=======================================
Hits 12018 12018
Misses 17176 17176
Partials 691 691 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested sign transaction and sign typed data with a keystone.
Description
This PR modifies the density of the animated QR codes so that they can be scanned by the ZERO hardware wallet from NGRAVE.
Original PR: #8300
Related issues
Fixes: NA
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist