Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace hex colors in constants file with tokens #8330

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jan 18, 2024

Description

  • Replace hex colors in constants file with tokens

Related issues

Fixes: #8331

Manual testing steps

  1. N/A

Screenshots/Recordings

N/A

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Jan 18, 2024
@brianacnguyen brianacnguyen self-assigned this Jan 18, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner January 18, 2024 16:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ideally this PR should have screenshots of the changes so we can be 100% confident there are no visual regressions

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64b7cb5) 39.83% compared to head (c6023e5) 40.33%.
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8330      +/-   ##
==========================================
+ Coverage   39.83%   40.33%   +0.50%     
==========================================
  Files        1233     1236       +3     
  Lines       29821    29976     +155     
  Branches     2840     2881      +41     
==========================================
+ Hits        11880    12092     +212     
+ Misses      17252    17188      -64     
- Partials      689      696       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen merged commit 3135ac7 into main Jan 24, 2024
26 checks passed
@brianacnguyen brianacnguyen deleted the nohex/ds branch January 24, 2024 22:00
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MOB] Replace hex colors with DS tokens in DS const files
4 participants