Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace hex colors in Android Media Player with ds brand tokens #8334

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Replace hex colors in Android Media Player with ds brand tokens

Related issues

Fixes: #8264

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

N/A

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Jan 18, 2024
@brianacnguyen brianacnguyen self-assigned this Jan 18, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner January 18, 2024 18:39
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (17b741e) 40.21% compared to head (5b50d5a) 40.20%.
Report is 15 commits behind head on main.

Files Patch % Lines
...components/Views/MediaPlayer/AndroidMediaPlayer.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8334      +/-   ##
==========================================
- Coverage   40.21%   40.20%   -0.01%     
==========================================
  Files        1235     1235              
  Lines       29883    29926      +43     
  Branches     2862     2872      +10     
==========================================
+ Hits        12018    12033      +15     
- Misses      17174    17200      +26     
- Partials      691      693       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ideally this PR should have screenshots of the changes so we can be 100% confident there are no visual regressions

@brianacnguyen brianacnguyen merged commit 4b95ce4 into main Jan 24, 2024
26 checks passed
@brianacnguyen brianacnguyen deleted the nohex/android-media-player branch January 24, 2024 20:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 24, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MOB] Replace hex colors with DS tokens in Android Media Player
4 participants