Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: E2E: Import SNX token #8341

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix: E2E: Import SNX token #8341

merged 2 commits into from
Jan 19, 2024

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Jan 19, 2024

Description

Update import-token.spec.js to import SNX token. This is due to flaky search results.

Related issues

Fixes: #8338

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chrisleewilcox chrisleewilcox self-assigned this Jan 19, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox marked this pull request as ready for review January 19, 2024 04:50
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner January 19, 2024 04:50
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 19, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a93585a1-3a6b-4a7d-b33f-e6763b95b25c
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e2a83f) 40.30% compared to head (41a88db) 40.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8341   +/-   ##
=======================================
  Coverage   40.30%   40.30%           
=======================================
  Files        1235     1235           
  Lines       29928    29928           
  Branches     2872     2872           
=======================================
  Hits        12062    12062           
  Misses      17173    17173           
  Partials      693      693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chrisleewilcox chrisleewilcox added Run E2E Smoke and removed Run Smoke E2E Triggers smoke e2e on Bitrise Run E2E Smoke labels Jan 19, 2024
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@chrisleewilcox chrisleewilcox merged commit afcaa91 into main Jan 19, 2024
32 checks passed
@chrisleewilcox chrisleewilcox deleted the fix/update-import-token branch January 19, 2024 22:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E: fix import-tokens test
5 participants