Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): add Terms of Service provider link to quotes #8354

Merged
merged 10 commits into from
Feb 15, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jan 19, 2024

Description

This PR adds a new link to the Provider information in Ramp Quotes: "Terms of Service"

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ONRAMP-1327

Manual testing steps

  1. Go through a Ramp flow (Buy or Sell)
  2. Get quotes
  3. When clicking on a provider info icon and the provider supports a "Terms of Service" link, it must be displayed.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Jan 19, 2024
@wachunei wachunei requested a review from a team as a code owner January 19, 2024 21:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1bec601) 41.07% compared to head (ef12b0d) 41.07%.

Files Patch % Lines
app/components/UI/Ramp/components/InfoAlert.tsx 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8354      +/-   ##
==========================================
- Coverage   41.07%   41.07%   -0.01%     
==========================================
  Files        1246     1246              
  Lines       30320    30326       +6     
  Branches     2962     2963       +1     
==========================================
+ Hits        12453    12455       +2     
- Misses      17123    17126       +3     
- Partials      744      745       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tommasini
tommasini previously approved these changes Jan 23, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 23, 2024
@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Feb 15, 2024
Copy link

sonarcloud bot commented Feb 15, 2024

@wachunei wachunei merged commit 3c19b71 into main Feb 15, 2024
26 checks passed
@wachunei wachunei deleted the feat/ramp-tos-link branch February 15, 2024 20:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run ramp-qa-passed release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants