-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create single functions to invoke Transaction Controller #8366
Create single functions to invoke Transaction Controller #8366
Conversation
ab52715
to
c48c16d
Compare
c48c16d
to
6281c2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @OGPoyraz !
I don't know if you already run the smoke test in Bitrise, in case not, you can use the tag Run Smoke E2E
.
ow, I think might be out of the scope as it's a utility function but reviewing your PR I just saw isEIP1559Transaction here in case you need to push some change we could fix that import as this function is already exported now.
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f2198355-549c-4198-bfe3-db841c59bddc |
Thanks @vinistevam , fixed the import, I think still worth running smoke e2e pipeline, I was fixing unit tests but it's good to go now. |
…action-controller-in-mobile
47eb63e
@sleepytanya this passing on Bitrise but a transaction regression would be awesome here |
This comment was marked as spam.
This comment was marked as spam.
@OGPoyraz QA build, physical device Samsung s24+, Sepolia, Linea Goerli and mainnet for swaps:
|
Very nice catch @sleepytanya ! I believe cancel transaction should work now |
QA build, physical Android Samsung s24+ - 'cancel' works as expected: |
…action-controller-in-mobile
1156c9b
to
a78085f
Compare
Quality Gate passedIssues Measures |
Description
This PR aims to add single function wrappers for each TransactionController method such as
addTransaction
andestimateGas
.Related issues
For more detail : https://github.com/MetaMask/mobile-planning/issues/1488
Manual testing steps
No QA needed since there is no functional change
Pre-merge author checklist
Pre-merge reviewer checklist
CI Related Section: DO NOT EDIT
Flag used by Bitrise to either run or skip E2E smoke tests