-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update network controller v^10 #8370
Conversation
…r gas fee controller, replace breaking changes on network controller and a migration for it, NetworkChainId to chainId on controller-utils
…tches for controller utils and assets-controllers, changed on new missing plances rpcTarget for rpcUrl, upgraded controller utils to v4
…onverting the chainId on that state for hexadecimal
… toggles on security and privacy settings
Fix chain ID middleware.
…st on networks constants for hexadecimal format
…Switch and some on Engine file
…h_chainId, also removed a type on test file of rpcMethodMiddleware
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/82be4116-01bd-4480-b2b5-5c7188f89c88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as code owner to unblock merge but have not tested this in any way. Please get another review from an engineer with context of these changes
Quality Gate passedIssues Measures |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbedbdbe-ca58-4495-9bbe-6fbbb89020bf |
Description
This PR aims to update network controller to version ^10.0.0 as part of the controllers upgrade to version v55
This PR also removes the existing patch, since it's no longer needed.
Also, it updates the assert package, because couldn't find
notStrictEqual
on the old version.This PR is blocked until the v53 last PR is merged, will be a draft until then
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
https://recordit.co/Mrnu9csKXG - Adding, Switching and removing network between networks on the popular list
https://recordit.co/Bmhhi1eOeG - Adding and Switching network from Dapps and Import it custom manually
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
CI Related Section: DO NOT EDIT
Flag used by Bitrise to either run or skip E2E smoke tests