Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update network controller v^10 #8370

Merged
merged 122 commits into from
Feb 14, 2024
Merged

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jan 23, 2024

Description

This PR aims to update network controller to version ^10.0.0 as part of the controllers upgrade to version v55

This PR also removes the existing patch, since it's no longer needed.
Also, it updates the assert package, because couldn't find notStrictEqual on the old version.

This PR is blocked until the v53 last PR is merged, will be a draft until then

Related issues

Fixes:

Manual testing steps

  1. Add/switch/remove networks from our popular list
  2. Add/switch/remove manually added
  3. Add/switch networs via Dapp

Screenshots/Recordings

https://recordit.co/Mrnu9csKXG - Adding, Switching and removing network between networks on the popular list
https://recordit.co/Bmhhi1eOeG - Adding and Switching network from Dapps and Import it custom manually

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

CI Related Section: DO NOT EDIT

Flag used by Bitrise to either run or skip E2E smoke tests

  • Bitrise Flag:[skip ci]

tommasini and others added 30 commits December 4, 2023 20:43
…r gas fee controller, replace breaking changes on network controller and a migration for it, NetworkChainId to chainId on controller-utils
…tches for controller utils and assets-controllers, changed on new missing plances rpcTarget for rpcUrl, upgraded controller utils to v4
…onverting the chainId on that state for hexadecimal
Fix chain ID middleware.
…st on networks constants for hexadecimal format
…h_chainId, also removed a type on test file of rpcMethodMiddleware
package.json Show resolved Hide resolved
Base automatically changed from feat/7490-chain-id-to-hex-format to main February 14, 2024 18:02
@tommasini tommasini dismissed MarioAslau’s stale review February 14, 2024 18:02

The base branch was changed.

@tommasini tommasini requested a review from a team as a code owner February 14, 2024 18:02
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 14, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/82be4116-01bd-4480-b2b5-5c7188f89c88
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as code owner to unblock merge but have not tested this in any way. Please get another review from an engineer with context of these changes

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 14, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbedbdbe-ca58-4495-9bbe-6fbbb89020bf
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@tommasini tommasini merged commit 8317c1c into main Feb 14, 2024
29 checks passed
@tommasini tommasini deleted the update/network-controller-v10 branch February 14, 2024 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-smoke-e2e release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants