Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compare checksum address #8374

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: Compare checksum address #8374

merged 2 commits into from
Jan 23, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jan 23, 2024

Description

This PR addresses https://github.com/MetaMask/mobile-planning/issues/1340
It fixes the missing highlighted address in the account selector sheet

Related issues

Fixes:

Manual testing steps

Open the account selector sheet on the wallet screen
Notice that the selected account should be highlighted

Screenshots/Recordings

Before

After

highlight.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner January 23, 2024 19:35
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 23, 2024
@Cal-L Cal-L added team-mobile-client Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 23, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/65a6ffbf-fed7-4b88-9343-18f5100d0b0e
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d26e45) 40.33% compared to head (eabf4fd) 40.32%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8374      +/-   ##
==========================================
- Coverage   40.33%   40.32%   -0.01%     
==========================================
  Files        1235     1235              
  Lines       29949    29948       -1     
  Branches     2875     2875              
==========================================
- Hits        12079    12078       -1     
  Misses      17175    17175              
  Partials      695      695              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 23, 2024

@Cal-L Cal-L merged commit 01c4a1a into main Jan 23, 2024
32 checks passed
@Cal-L Cal-L deleted the fix/1340-highlight-account branch January 23, 2024 21:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 23, 2024
@Cal-L Cal-L added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.16.0 Issue or pull request that will be included in release 7.16.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants