-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Compare checksum address #8374
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…to fix/1340-highlight-account
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/65a6ffbf-fed7-4b88-9343-18f5100d0b0e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8374 +/- ##
==========================================
- Coverage 40.33% 40.32% -0.01%
==========================================
Files 1235 1235
Lines 29949 29948 -1
Branches 2875 2875
==========================================
- Hits 12079 12078 -1
Misses 17175 17175
Partials 695 695 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
This PR addresses https://github.com/MetaMask/mobile-planning/issues/1340
It fixes the missing highlighted address in the account selector sheet
Related issues
Fixes:
Manual testing steps
Open the account selector sheet on the wallet screen
Notice that the selected account should be highlighted
Screenshots/Recordings
Before
After
highlight.mov
Pre-merge author checklist
Pre-merge reviewer checklist