fix: Minimize skipping tests

[chrisleewilcox]

Description

Running tests based on TEST_SUITE only requires skipping a lot of tests which takes significant time for the testrun to complete. Isolating tests suite within the tests folder will only skip tests within that folder significantly reducing tests run times.

This change applies to SmokeConfirmations and SmokeSwaps. SmokeCore tests are located in multiple folders and will still skip tests that are not SmokeCore.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2652a24) 40.44% compared to head (c58b12e) 40.44%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8375   +/-   ##
=======================================
  Coverage   40.44%   40.44%           
=======================================
  Files        1239     1239           
  Lines       29975    29975           
  Branches     2875     2875           
=======================================
  Hits        12122    12122           
  Misses      17156    17156           
  Partials      697      697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/85b192ee-2060-43e9-a5e4-4fcb71570c6d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[leotm]

🚀

[leotm]

should be good to update branch now ^

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud