Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update assets controllers v^9.0.0 #8378

Merged
merged 119 commits into from
Feb 14, 2024
Merged

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jan 24, 2024

Description

The issue still needs validation.
On this PR was rebased all the packages on assets controllers present on this core branch: v53-mobile-assets-controllers-patch with the exception of:

Still have a warning when it renders the app from a cold start undefined is not an object (evaluating 'inputBn.toString') This error is on the refresh function on the AccountTrackerController and still under investigation. Good to mention that the behavior of the app still seems the same, since it recovers from the warning.

Core branch with specific updates: v55-mobile-assets-controllers-patch

Patches needed

  • AccountTrackerController
  • What happened
    • BNToHex function was receiving an value undefined and prompint an error
  • Solution
    • Needed to patch AccountTrackerController, core commit change line 201, balance was returning undefined and not being handled
      (Keep in mind this commit have more changes Because I'm updating all the changes of the assets-controller since version 8 in this branch, for being easier to update the patches on mobile)
      I believe this is fixed on future versions where the networkId is implemented together with a mutex logic

Still need recordings of everything around assets: Tokens, NFTs, privacy settings working

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

tommasini and others added 30 commits December 4, 2023 20:43
…r gas fee controller, replace breaking changes on network controller and a migration for it, NetworkChainId to chainId on controller-utils
…tches for controller utils and assets-controllers, changed on new missing plances rpcTarget for rpcUrl, upgraded controller utils to v4
…onverting the chainId on that state for hexadecimal
Fix chain ID middleware.
…st on networks constants for hexadecimal format
…h_chainId, also removed a type on test file of rpcMethodMiddleware
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 2, 2024
@tommasini
Copy link
Contributor Author

MarioAslau
MarioAslau previously approved these changes Feb 14, 2024
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Tomas!

Base automatically changed from feat/7490-chain-id-to-hex-format to main February 14, 2024 18:02
@tommasini tommasini dismissed MarioAslau’s stale review February 14, 2024 18:02

The base branch was changed.

@tommasini tommasini requested a review from a team as a code owner February 14, 2024 18:02
@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 14, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf360295-9ce3-4815-845b-a72bf268a1ac
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@georgewrmarshall
Copy link
Contributor

Approving as code owner to unblock merge but have not tested this in any way. Please get another review from an engineer with context of these changes

@tommasini tommasini merged commit 7956445 into main Feb 14, 2024
28 checks passed
@tommasini tommasini deleted the update/8358-assets-controllers-v9 branch February 14, 2024 22:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 14, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants