Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add translation for privacy toggle #8383

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 24, 2024

Description

the goal of this PR is to add translation for the feature add privacy toggle

Fixes: #1269

Manual testing steps

  1. the locals will be used in another PR , this commit will be cherry-picked

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner January 24, 2024 15:07
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the feat/translation-for-privacy-toggle branch from 14c6151 to d8bd5eb Compare January 24, 2024 15:08
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 24, 2024
@salimtb salimtb added No E2E Smoke Needed If the PR does not need E2E smoke test run area-translation For Blendin translation. and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 24, 2024
@salimtb salimtb mentioned this pull request Jan 24, 2024
13 tasks
locales/languages/en.json Outdated Show resolved Hide resolved
locales/languages/en.json Outdated Show resolved Hide resolved
@salimtb salimtb force-pushed the feat/translation-for-privacy-toggle branch from 540f7a5 to 7737c76 Compare January 24, 2024 15:55
@salimtb salimtb force-pushed the feat/translation-for-privacy-toggle branch from 7737c76 to ecafc91 Compare January 24, 2024 16:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fa1dd8) 40.34% compared to head (7737c76) 40.34%.

❗ Current head 7737c76 differs from pull request most recent head ecafc91. Consider uploading reports for the commit ecafc91 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8383   +/-   ##
=======================================
  Coverage   40.34%   40.34%           
=======================================
  Files        1235     1235           
  Lines       29957    29957           
  Branches     2877     2877           
=======================================
  Hits        12087    12087           
  Misses      17175    17175           
  Partials      695      695           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@salimtb salimtb merged commit 2b3e31c into main Jan 25, 2024
24 checks passed
@salimtb salimtb deleted the feat/translation-for-privacy-toggle branch January 25, 2024 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-translation For Blendin translation. No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants