-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump restore cache step in Bitrise #8384
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f13f7788-ff1a-46fa-9afd-7e575e990433 |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a38c1bff-654e-46e1-b807-e6731eec17a8 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8384 +/- ##
=======================================
Coverage 40.40% 40.40%
=======================================
Files 1240 1240
Lines 29993 29993
Branches 2878 2878
=======================================
Hits 12120 12120
Misses 17175 17175
Partials 698 698 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
This PR aims to fix an issue where restore-cache steps in Bitrise where getting stuck and breaking pipelines.
After some investigation the latest version of the step restore-cache fixes an issue with the retry mechanism when a chunk (part) download fails the step will retry the download of that specific chunk. Preventing the step from getting stuck.
Additionally taking the opportunity to update all the restore steps to version 2 which includes multithread download, which might save us some seconds in each run.
Related issues
Fixes: #8360
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist