Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump restore cache step in Bitrise #8384

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Jan 24, 2024

Description

This PR aims to fix an issue where restore-cache steps in Bitrise where getting stuck and breaking pipelines.

After some investigation the latest version of the step restore-cache fixes an issue with the retry mechanism when a chunk (part) download fails the step will retry the download of that specific chunk. Preventing the step from getting stuck.

Additionally taking the opportunity to update all the restore steps to version 2 which includes multithread download, which might save us some seconds in each run.

Related issues

Fixes: #8360

Manual testing steps

  1. Run smoke and regression tests

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Jan 24, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 24, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f13f7788-ff1a-46fa-9afd-7e575e990433
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@vinistevam
Copy link
Contributor Author

@vinistevam vinistevam marked this pull request as ready for review January 25, 2024 08:04
@vinistevam vinistevam requested a review from a team as a code owner January 25, 2024 08:04
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a38c1bff-654e-46e1-b807-e6731eec17a8
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a44cb3) 40.40% compared to head (1137722) 40.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8384   +/-   ##
=======================================
  Coverage   40.40%   40.40%           
=======================================
  Files        1240     1240           
  Lines       29993    29993           
  Branches     2878     2878           
=======================================
  Hits        12120    12120           
  Misses      17175    17175           
  Partials      698      698           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinistevam vinistevam removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 25, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vinistevam vinistevam merged commit f2b9fd6 into main Jan 25, 2024
26 checks passed
@vinistevam vinistevam deleted the fix/restore-cache-breaking-pipeline branch January 25, 2024 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitrise: Restoring cache dependencies sometimes take over 10 minutes
4 participants